Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for readOnly to disable Menu button #63

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add support for readOnly to disable Menu button #63

merged 3 commits into from
Jan 17, 2024

Conversation

luizhop
Copy link
Contributor

@luizhop luizhop commented Dec 22, 2023

  • Issue Read-only field #61
  • Add support for disabling IconPicker Menu Button according to readOnly property on schema

christopherafbjur
christopherafbjur requested changes Jan 17, 2024
View reviewed changes
Copy link
Owner

@christopherafbjur christopherafbjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some linting warnings/errors

src/components/Menu.test.tsx Outdated Show resolved Hide resolved
src/components/Menu.test.tsx Outdated Show resolved Hide resolved
christopherafbjur
christopherafbjur approved these changes Jan 17, 2024
View reviewed changes
Copy link
Owner

@christopherafbjur christopherafbjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed these minor linting hickups from the pipeline so we can get your PR merged :) Thanks for your contribution @luizhop

@christopherafbjur christopherafbjur merged commit 65995ee into christopherafbjur:main Jan 17, 2024
1 check passed
@christopherafbjur christopherafbjur mentioned this pull request Jan 17, 2024
Closed
@luizhop luizhop deleted the feat/61-readonly-field branch January 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherafbjur christopherafbjur christopherafbjur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizhop @christopherafbjur